Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move custom error hint for insert to a package extension #159

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MasonProtter
Copy link
Contributor

This is a followup PR to #140

On modern versions of julia, moving this code to a package extension should have no observable changes, but it makes it so that Accessors.jl doesn't unconditionally load Markdown.jl, and only ends up using it if it's already loaded (which will be the case for interactive sessions of julia, but might not be the case if one is doing something like making a small binary and are stripping stdlibs.

I'd argue that in such a situation, this error hint isn't necessary or desirable anyways.

@aplavin
Copy link
Member

aplavin commented Jul 26, 2024

Tbh, I would vote for just removing Markdown and keeping the hint in __init__. Adding a separate extension just for a bit of highlights in a rare exception hint appears a bit too much...

But if others are in favor, this should be fine I guess.

@jw3126
Copy link
Member

jw3126 commented Jul 26, 2024

I agree with @aplavin lets keep it simple stupid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants