-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to test suite to support CUDA arrays #118
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
==========================================
+ Coverage 93.70% 93.73% +0.02%
==========================================
Files 5 5
Lines 445 447 +2
==========================================
+ Hits 417 419 +2
Misses 28 28
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Random.rand!
usage
197ca26
to
31755f0
Compare
Bump on review:) It should hopefully be an easy review, especially because this does not touch the core functionality, only the test utilities, which I have verified continue to work with |
…s for wrapper tests" This reverts commit e46b8eb.
Bump |
Bump on review. @devmotion raised in #118 (comment)) the issue of |
Implemented changes:
test_plan_adjoint
*
(see Handling wrapper array inputs #119. I don't expect it to be solved in the immediate future, which is why I prefer to work around it for now).fftdims
as an iterable rather than its specific form, in accordance with the function contract.