Restrict LinearAlgebra.onedefined to concrete number types #52632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
onedefined
more conservative, so that nowIn general, we cannot guarantee that
oneunit
works with abstract or union types. After this, the following contrived example works correctly instead of throwing an error:This change widens certain inferred types. E.g., on master:
whereas, in this PR, this returns a
Vector{Any}
. This may be acceptable, though, if one starts with abstract types.