Skip to content

Commit

Permalink
Make BitSet field const (#43553)
Browse files Browse the repository at this point in the history
  • Loading branch information
@jakobnissen
jakobnissen authored Jan 5, 2022
1 parent b9432a8 commit 98b485e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion base/bitset.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const NO_OFFSET = Int === Int64 ? -one(Int) << 60 : -one(Int) << 29
# a small optimization in the in(x, ::BitSet) method

mutable struct BitSet <: AbstractSet{Int}
bits::Vector{UInt64}
const bits::Vector{UInt64}
# 1st stored Int equals 64*offset
offset::Int

Expand Down

4 comments on commit 98b485e

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@vtjnash
Copy link
Member

@vtjnash vtjnash commented on 98b485e Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

Please sign in to comment.