Update a few things for v0.7 #460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musm
reviewed
Jan 17, 2018
src/HDF5.jl
Outdated
| push!(row, reshape(val, size(dtype))) | ||
| elseif dtype<:HDF5BitsKind | ||
| push!(row, read(io, dtype)) | ||
| else | ||
| # for other types, just store the raw bytes and let the user | ||
| # decide what to do | ||
| push!(row, read!(io, Vector{UInt8}(dsize))) | ||
| push!(row, read!(io, @compat Vector{UInt8}(uninitialized, dsize))) |
There was a problem hiding this comment.
I don't think any of the modifications in this file require @compact, otherwise lgtm
musm
reviewed
Jan 17, 2018
src/HDF5.jl
Outdated
| @@ -1999,16 +2001,16 @@ for (jlname, h5name, outtype, argtypes, argsyms, msg) in | |||
| (:h5_open, :H5open, Herr, (), (), "Error initializing the HDF5 library"), | |||
| (:h5_set_free_list_limits, :H5set_free_list_limits, Herr, (Cint, Cint, Cint, Cint, Cint, Cint), (:reg_global_lim, :reg_list_lim, :arr_global_lim, :arr_list_lim, :blk_global_lim, :blk_list_lim), "Error setting limits on free lists"), | |||
| (:h5a_close, :H5Aclose, Herr, (Hid,), (:id,), "Error closing attribute"), | |||
| (:h5a_write, :H5Awrite, Herr, (Hid, Hid, Ptr{Void}), (:attr_hid, :mem_type_id, :buf), "Error writing attribute data"), | |||
| (:h5a_write, :H5Awrite, Herr, (Hid, Hid, Ptr{Nothing}), (:attr_hid, :mem_type_id, :buf), "Error writing attribute data"), | |||
|
superseded by #468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't tell if my other PR is breaking things, so here's an attempt at updating what I can for the latest master branch of julia. These are mostly mechanical search and replace fixes based on error and warning messages. Only a couple are required for the tests to pass, but the others help with deprecation warnings. I tried to use the Compat package so I hope this won't break previous versions.
Let's see what travis says...