Update LICENSE #105
Update LICENSE #105
Conversation
|
LLVM relicensed to Apache2 + LLVM exception. We should make our modifications available under both licenses in case someone wants to use it with a newer llvm. |
|
I do not know enough details about the new LLVM license to modify the license text appropriately. Feel free to directly edit this PR. |
|
I think we may need to contact the LLVM legal team to clarify that. I think either our contributions are already automatically dual-licensed (since we signed the agreement for it), or the whole repo remains with the old license? It might be especially tricky, since we've gotten other outside contributions under this license since splitting of, and we can't just relicense those without confirmation from those authors for their patches here. I would also say "changes" rather than "enhancements" so that there is clarity we meant all patches, not just new features. |
|
c.f. #87 for past discussion |
|
When I made #87 I initially thought about making a contribution that would change all the licence headers. But in the end I didn't, because (IANAL) the fact the old licence allows sublicensing means we can change to the new LLVM license at any time, so I didn't see a benefit of doing it immediately. |
| All changes to LLVM-CBE contributed by Julia Computing are made available under | ||
| the original University of Illinois/NCSA Open Source License. | ||
| Copyright(c) 2015-2021 Julia Computing. | ||
|
|
There was a problem hiding this comment.
Nitpick: that this is the old LLVM licence is obvious from the rest of the file, so maybe this statement is more useful if placed in the README instead?
(I have nothing useful to say about the copyright line.)
|
I'm merging this - but if incorrectly done or there's a better way, please update accordingly. |
|
The copyright statement seems fine, insofar as it establishes the contributions from Julia Computing are owned by Julia Computing. Any contributions by outsiders aren't though, unless there was an explicit copyright assignment. |
|
Yes, that's right. We do not have a copyright assignment. Happy to update it to reflect better language. Perhaps something like this makes it clearer? |
|
That sounds good to me. |
@vtjnash @Keno @StefanKarpinski Please see if this is ok, or can be done in a better way.