Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MetaGraphs.jl #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

filchristou
Copy link
Contributor

Code from (unregistered) NestedGraphIO.jl returns home as described in #49.
This PR enables support for MetaGraphs in GraphML format.
It follows the paradigm of http://graphml.graphdrawing.org/ to define attributes in the graph.
The following features are supported:

  1. the key/data extension mechanism
  2. default values for keys
  3. loading/saving graphs or Dict of graphs

The implementation is done using XPath and DOM and not the EzXML.StreamReader for the reason that there needs to be some memory on the parser in order to remember whose are the properties read.

The current API is a bit different. The reason is that now the user now needs also to pass an extra argument to mention the desired graph type s/he wishes to parse (in this case ::MetaGraphs.MGFormat).

@filchristou
Copy link
Contributor Author

let me know if you are concerned about the codecov reduce.

@filchristou
Copy link
Contributor Author

@simonschoelly I think this should be merged. It can be helpful for people. Any concerns ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant