Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm deps/build.jl #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IanButterworth
Copy link

@IanButterworth IanButterworth commented Jan 6, 2024

I don't understand why this is done during the build step with a fall back to the precompile step.

Seems wasteful to do it during build, especially given it causes re-precompilation if the user calls Pkg.build

If it's for development purposes, then this PR should still work.

@SimonDanisch

@IanButterworth
Copy link
Author

bump

1 similar comment
@IanButterworth
Copy link
Author

bump

@SimonDanisch
Copy link
Member

Sorry, pretty low priority for me I wonder if we should leave the build/deps.jl at if it's created manually?
I think I had it in build to have an easy way to recompile the package with debugging on/off on demand.
I guess it's fine to leave in the precompile step, considering that I ended up switching between debug mode pretty rarely.

@IanButterworth
Copy link
Author

Low priority bump. Just seems to be an odd pattern in modern package installation?

@SimonDanisch
Copy link
Member

I'm still not sure how to turn this on and trigger recompoliation after adding ModernGL...
I just wanted to post a description how to turn on debugging for ModernGL, but I'm really not sure what that would be with this PR merged.
Dev ModernGL and set the env var before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants