Fix bug with greedy scheduler hitting empty collections #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I think I like this more. BTW, you can copy the changelog entry from my PR if you want. |
|
One lingering concern is that if base changes the representation for their empty reduction error, this patch could fail. I tried doing the filtering at the site of the reduction though (test if the channel is closed and if the channel is empty) and it didn't really work. |
|
Okay, I've added a code comment basically marking out my concern about how this might break in the future, but I think for now its good enough. |
This was referenced Mar 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation to #83. I think this way is slightly more robust since we're not passing around
nothingand we're only ignoring method errors for whiche.f == Base.mapreduce_empty.