-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full scheduler::Symbol
support + Keyword argument forwarding
#81
Conversation
I think that tests are failing because of #82. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow that ended up being quite involved to do! Looks good to me. This is really starting to make me wish there was a package or something that made it easier to deal with "computed kwargs", because doing this right can get quite complex.
Oops, meant to hit "approve" |
Terminology: By "top-level" keyword arguments I refer to keyword arguments that are directly provided to the parallel function API, e.g to
tmapreduce
,tmap
, etc. (in contrast to those provided to aScheduler
constructor).Principle:
If
scheduler isa Symbol
, then (most) "top-level" keyword arguments are forwarded to the constructor of theScheduler
that corresponds to the symbol (if any). Ifscheduler isa Scheduler
, to avoid ambiguity, we error if a scheduler option is provided as a "top-level" keyword argument.Examples (see docstrings and
runtests.jl
for more):More:
StaticScheduler
andDynamicScheduler
now can also take antasks
keyword argument which is just an alias fornchunks
.DynamicScheduler
now defaults tontasks=nthreads()
(again).Besides implementing these features, I found and fixed some minor code, docstring, and testing bugs.
Closes #76.