Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public keyword #217

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Add public keyword #217

merged 1 commit into from
Dec 13, 2024

Conversation

emmt
Copy link
Contributor

@emmt emmt commented Dec 13, 2024

This PR adds the public keyword that appears in Julia ≥ 1.11 with the same semantics as export.

Copy link
Collaborator

@tpapp tpapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I don't think we need separate tests for this as it uses the same logic as export, which we test for.

@tpapp
Copy link
Collaborator

tpapp commented Dec 13, 2024

@non-Jedi @giordano @FelipeLema @ajhalme

if one of you could please provide an additional review, I would merge

Copy link
Contributor

@FelipeLema FelipeLema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tpapp tpapp merged commit 3823931 into JuliaEditorSupport:master Dec 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants