-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MTK Jacobian for CoupledDEs #229
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
==========================================
+ Coverage 82.00% 86.43% +4.42%
==========================================
Files 15 17 +2
Lines 717 936 +219
==========================================
+ Hits 588 809 +221
+ Misses 129 127 -2 ☔ View full report in Codecov by Sentry. |
sorry for the late reply! |
@@ -130,9 +133,11 @@ deterministic part of `ds`. | |||
""" | |||
function DynamicalSystemsBase.CoupledODEs( | |||
sys::CoupledSDEs; diffeq=DEFAULT_DIFFEQ, t0=0.0) | |||
prob = referrenced_sciml_prob(sys) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be nothing
if the system is not constructed through MTK. Doesn't this break normal systems? You cna't do prob.f
then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It think you are confused with referrenced_sciml_model
. Every ContineousTimeDynamicalSystem
is made through a DEProblem
. See
DynamicalSystemsBase.jl/src/core_systems/continuous_time_ode.jl
Lines 82 to 88 in 7b7ac7a
function CoupledODEs(f, u0, p = SciMLBase.NullParameters(); t0 = 0, diffeq = DEFAULT_DIFFEQ) | |
IIP = isinplace(f, 4) # from SciMLBase | |
s = correct_state(Val{IIP}(), u0) | |
T = eltype(s) | |
prob = ODEProblem{IIP}(f, s, (T(t0), T(Inf)), p) | |
return CoupledODEs(prob, diffeq) | |
end |
resolves #228