Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tape printing #252

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Fix tape printing #252

merged 3 commits into from
Apr 16, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Apr 14, 2024

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test (eg using string or an IOBuffer?)?

src/tape.jl Outdated Show resolved Hide resolved
Co-authored-by: David Widmann <[email protected]>
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.47%. Comparing base (c982cde) to head (d1fc4b6).
Report is 1 commits behind head on master.

❗ Current head d1fc4b6 differs from pull request most recent head f5ce5fb. Consider uploading reports for the commit f5ce5fb to get more accurate results

Files Patch % Lines
src/tape.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage   81.53%   81.47%   -0.07%     
==========================================
  Files          18       18              
  Lines        1587     1576      -11     
==========================================
- Hits         1294     1284      -10     
+ Misses        293      292       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Member Author

gdalle commented Apr 16, 2024

Can you add a test (eg using string or an IOBuffer?)?

done

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@gdalle gdalle merged commit 228e7c7 into master Apr 16, 2024
4 of 5 checks passed
@gdalle gdalle deleted the gd/fixprint branch April 16, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type analysis depth limit / task switch not allowed from inside staged nor pure functions
2 participants