-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exponentiation for NaNMath.pow
#717
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #717 +/- ##
==========================================
- Coverage 89.57% 86.75% -2.83%
==========================================
Files 11 10 -1
Lines 969 921 -48
==========================================
- Hits 868 799 -69
- Misses 101 122 +21 ☔ View full report in Codecov by Sentry. |
Can you add a few cases to the tests? Ideally NaN/not/negative through both paths. |
devmotion
reviewed
Nov 1, 2024
devmotion
reviewed
Nov 1, 2024
Co-authored-by: David Widmann <[email protected]>
devmotion
reviewed
Nov 4, 2024
devmotion
reviewed
Nov 4, 2024
Co-authored-by: David Widmann <[email protected]>
devmotion
approved these changes
Nov 8, 2024
devmotion
added a commit
that referenced
this pull request
Nov 8, 2024
* fix NaNMath exponentiation * reuse code * fix * add tests * Update src/dual.jl Co-authored-by: David Widmann <[email protected]> * import NaNMath * oops, no begin * Update test/GradientTest.jl Co-authored-by: David Widmann <[email protected]> --------- Co-authored-by: David Widmann <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently an example like this:
errors. I'd like to make it so that it returns a
NaN
instead.Fixes #716