Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better handling of Enzyme split mode + run Enzyme tests on 1.11 #654

Merged
merged 9 commits into from
Dec 5, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Dec 4, 2024

New attempt at #615.

DI extensions

Enzyme:

  • Add EnzymeCore as an explicit dependency of the Enzyme extension.
  • Use new mode splitter to forward characteristics of combined mode to its split counterpart

DI tests

Enzyme:

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.58%. Comparing base (881fc3f) to head (81e566b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   97.53%   97.58%   +0.05%     
==========================================
  Files         112      111       -1     
  Lines        5561     5552       -9     
==========================================
- Hits         5424     5418       -6     
+ Misses        137      134       -3     
Flag Coverage Δ
DI 98.74% <100.00%> (+0.07%) ⬆️
DIT 95.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle changed the title test: run Enzyme tests on Julia 1.11 fix: take into account Enzyme activities for split mode + run Enzyme tests on 1.11 Dec 5, 2024
@gdalle gdalle changed the title fix: take into account Enzyme activities for split mode + run Enzyme tests on 1.11 fix: better handling of Enzyme split mode + run Enzyme tests on 1.11 Dec 5, 2024
@gdalle gdalle added the skipci Don't run CI tests and docs label Dec 5, 2024
@gdalle gdalle merged commit 3abcee1 into main Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skipci Don't run CI tests and docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant