Skip to content

Commit

Permalink
Simplify frule for Base.tail (#650)
Browse files Browse the repository at this point in the history
* rm Tuple

* versions
  • Loading branch information
mcabbott authored Jul 19, 2022
1 parent 7faaf5d commit 9adf759
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ChainRules"
uuid = "082447d4-558c-5d27-93f4-14fc19e9eca2"
version = "1.39.0"
version = "1.39.1"

[deps]
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
Expand All @@ -14,7 +14,7 @@ SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"

[compat]
ChainRulesCore = "1.12"
ChainRulesCore = "1.15.3"
ChainRulesTestUtils = "1.5"
Compat = "3.42.0, 4"
FiniteDifferences = "0.12.20"
Expand Down
2 changes: 1 addition & 1 deletion src/rulesets/Base/indexing.jl
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ end

function frule((_, ẋ), ::typeof(Base.tail), x::Tuple)
y = Base.tail(x)
return y, Tangent{typeof(y)}(Base.tail(Tuple(ẋ))...)
return y, Tangent{typeof(y)}(Base.tail()...)
end

function rrule(::typeof(Base.tail), x::T) where {T<:Tuple}
Expand Down

2 comments on commit 9adf759

@mcabbott
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/64559

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.39.1 -m "<description of version>" 9adf759bc63432dc518ccf499d6938fc5a217113
git push origin v1.39.1

Please sign in to comment.