-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better checking of versions, other bugfixes #30
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #30 +/- ##
==========================================
- Coverage 58.33% 50.90% -7.43%
==========================================
Files 6 6
Lines 96 110 +14
==========================================
Hits 56 56
- Misses 40 54 +14 ☔ View full report in Codecov by Sentry. |
I'm all ok with the current state or version handling in PerfChecker. We do have file conflicts though, would you mind merging with Side note:
Maybe we can fix that now. |
Also, @VarLad , we need better tests in the sense that the current tests do not use the versions' system that you implemented. Furthermore, we need to fix the same things in the |
I believe new tests and separation of creating the dictionary as a variable from macro parameters should be done in another PR. |
No description provided.