Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better checking of versions, other bugfixes #30

Merged
merged 11 commits into from
Mar 29, 2024
Merged

Better checking of versions, other bugfixes #30

merged 11 commits into from
Mar 29, 2024

Conversation

VarLad
Copy link
Collaborator

@VarLad VarLad commented Mar 29, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 50.90%. Comparing base (30ffa3d) to head (3555404).

Files Patch % Lines
src/versions.jl 0.00% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #30      +/-   ##
==========================================
- Coverage   58.33%   50.90%   -7.43%     
==========================================
  Files           6        6              
  Lines          96      110      +14     
==========================================
  Hits           56       56              
- Misses         40       54      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Azzaare
Copy link
Member

Azzaare commented Mar 29, 2024

I'm all ok with the current state or version handling in PerfChecker.

We do have file conflicts though, would you mind merging with dev and push them again?

Side note:

┌ Warning: `cpucores_total()` is deprecated, use `cputhreads()` instead.
│   caller = macro expansion at check.jl:22 [inlined]
└ @ Core ~/.julia/dev/PerfChecker/src/check.jl:22

Maybe we can fix that now.

@Azzaare
Copy link
Member

Azzaare commented Mar 29, 2024

Also, @VarLad , we need better tests in the sense that the current tests do not use the versions' system that you implemented. Furthermore, we need to fix the same things in the perf folder for GLM and PatternFolds.

@VarLad
Copy link
Collaborator Author

VarLad commented Mar 29, 2024

I believe new tests and separation of creating the dictionary as a variable from macro parameters should be done in another PR.
I've resolved the conflicts and fixed the mentioned warning.

@Azzaare Azzaare merged commit 2aa5310 into dev Mar 29, 2024
5 of 9 checks passed
@Azzaare Azzaare deleted the tagsystem branch May 20, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants