Improves bench and chair. Allocs still need to be done

JuliaConstraints · Jun 8, 2024 · cdcb050 · cdcb050
1 parent 3755c95
commit cdcb050
Show file tree

Hide file tree

Showing 37 changed files with 10,082 additions and 9 deletions.
diff --git a/ext/MakieExt/allocs.jl b/ext/MakieExt/allocs.jl
@@ -67,11 +67,22 @@ function PerfChecker.checkres_to_scatterlines(
     ax.ylabel = "bytes"
     colors = make_colors(length(keys(di)))
     i = 1
+
+    lx = length(versionnums)
+    ly = length(keys(di))
+    step = 0.02 * (lx - 1)
+    diff = (1 - ly) * step / 2.0
+
+    @info "Plotting allocations" lx ly step diff
+
     for (keys, values) in di
-        xs = [values[i][1] for i in eachindex(values)]
+        xs = [values[i][1] for i in eachindex(values)] .+ diff
         ys = [versions[values[i][2]] for i in eachindex(values)]
         scatterlines!(f[1, 1], ys, xs, label = keys, color = (colors[i], 0.6))
         i += 1
+        diff += step
+
+        @info "Plotting allocations" xs ys
     end
     ax.title = x.pkgs[1].name
     Legend(f[1, 2], ax)

diff --git a/ext/MakieExt/bench.jl b/ext/MakieExt/bench.jl
@@ -21,23 +21,29 @@ function PerfChecker.checkres_to_scatterlines(
     ax = f[1, 1] = Axis(f)
     colors = make_colors(length(props))
     max = 2
-    diff = 0.0
+
+    lx = length(versionnums)
+    ly = length(data[1])
+    step = 0.02 * (lx - 1)
+    diff = (1 - ly) * step / 2.0
+
     for i in eachindex(data[1])
         xs = collect(eachindex(versionnums)) .+ diff
         ys = [isempty(v[i]) ? 0 : d[i][j] / r[i] for j in eachindex(d[i])]
         t = maximum(ys)
         if max < ϵ(t)
             max = ϵ(t)
         end
-        scatterlines!(xs, ys, label = string(props[i]), color = (colors[i], 0.4))
-        diff += 0.1 / length(xs)
+        scatterlines!(
+            xs, ys; label = string(props[i]), color = (colors[i], 1.0), linewidth = 0.5)
+        diff += step
     end
     ax.yscale = Makie.pseudolog10
     ax.xticks = (eachindex(versionnums), string.(versionnums))
     ax.xlabel = "versions"
     ax.ylabel = "ratio"
     ax.title = "Evolution for $(x.pkgs[1].name) (via BenchmarkTools.jl)"
-    ylims!(; high = max)
+    # ylims!(; high = max)
     f[1, 2] = Legend(f, ax)
     return f
 end

diff --git a/ext/MakieExt/chair.jl b/ext/MakieExt/chair.jl
@@ -21,23 +21,29 @@ function PerfChecker.checkres_to_scatterlines(
     ax = f[1, 1] = Axis(f)
     colors = make_colors(length(props))
     max = 2
-    diff = 0
+
+    lx = length(versionnums)
+    ly = length(data[1])
+    step = 0.02 * (lx - 1)
+    diff = (1 - ly) * step / 2.0
+
     for i in eachindex(data[1])
         xs = collect(eachindex(versionnums)) .+ diff
         ys = [isempty(v[i]) ? 0 : d[i][j] / r[i] for j in eachindex(d[i])]
         t = maximum(ys)
         if max < ϵ(t)
             max = ϵ(t)
         end
-        diff += 0.1 / length(xs)
-        scatterlines!(xs, ys, label = string(props[i]), color = (colors[i], 0.4))
+        scatterlines!(
+            xs, ys; label = string(props[i]), color = (colors[i], 1.0), linewidth = 0.5)
+        diff += step
     end
     ax.yscale = Makie.pseudolog10
     ax.xticks = (eachindex(versionnums), string.(versionnums))
     ax.xlabel = "versions"
     ax.ylabel = "ratio"
     ax.title = "Evolution for $(x.pkgs[1].name) (via Chairmarks.jl)"
-    ylims!(; high = max)
+    # ylims!(; high = max)
     f[1, 2] = Legend(f, ax)
     return f
 end

diff --git a/perf/GLM/visuals/bench_evolution.png b/perf/GLM/visuals/bench_evolution.png
diff --git a/perf/GLM/visuals/chair_evolution.png b/perf/GLM/visuals/chair_evolution.png
diff --git a/perf/PatternFolds/metadata/metadata.csv b/perf/PatternFolds/metadata/metadata.csv
@@ -8,3 +8,18 @@ benchmark_PatternFolds_v0.2.1_patterns_intervals,e0de2879-5d35-4872-bb8d-5e09222
 benchmark_PatternFolds_v0.2.2_patterns_intervals,e0de2879-5d35-4872-bb8d-5e092227a858
 benchmark_PatternFolds_v0.2.3_patterns_intervals,e0de2879-5d35-4872-bb8d-5e092227a858
 benchmark_PatternFolds_v0.2.4_patterns_intervals,e0de2879-5d35-4872-bb8d-5e092227a858
+alloc_PatternFolds_v0.2.0_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62
+alloc_PatternFolds_v0.2.1_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62
+alloc_PatternFolds_v0.2.2_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62
+alloc_PatternFolds_v0.2.3_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62
+alloc_PatternFolds_v0.2.4_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62
+benchmark_PatternFolds_v0.2.0_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62
+benchmark_PatternFolds_v0.2.1_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62
+benchmark_PatternFolds_v0.2.2_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62
+benchmark_PatternFolds_v0.2.3_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62
+benchmark_PatternFolds_v0.2.4_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62
+chairmark_PatternFolds_v0.2.0_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62
+chairmark_PatternFolds_v0.2.1_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62
+chairmark_PatternFolds_v0.2.2_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62
+chairmark_PatternFolds_v0.2.3_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62
+chairmark_PatternFolds_v0.2.4_patterns_intervals,36c9068f-2e67-410b-b8bb-d57c1b476f62