Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Aqua stale deps check in downstream tests #398

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Skip Aqua stale deps check in downstream tests #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/downstream.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
# force it to use this PR's version of the package
Pkg.develop(PackageSpec(path=".")) # resolver may fail with main deps
Pkg.update()
Pkg.test(; coverage = true) # resolver may fail with test time deps
Pkg.test(; coverage = true, test_args=["--downstream_integration_test"]) # resolver may fail with test time deps
catch err
err isa Pkg.Resolve.ResolverError || rethrow()
# If we can't resolve that means this is incompatible by SemVer and this is fine
Expand Down
2 changes: 2 additions & 0 deletions test/aqua.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
using Aqua
using FillArrays
using Test
downstream_test = "--downstream_integration_test" in ARGS
@testset "Project quality" begin
Aqua.test_all(FillArrays;
# https://github.com/JuliaArrays/FillArrays.jl/issues/105#issuecomment-1582516319
ambiguities=(; broken=true),
stale_deps = !downstream_test,
)
end
Loading