coefficient conversion bugfix (#146)

JuliaApproximation · Aug 7, 2022 · 51b9aa0 · 51b9aa0 · jishnub · Aug 8, 2022
1 parent 6cf64e7
commit 51b9aa0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "ApproxFunBase"
 uuid = "fbd15aa5-315a-5a7d-a8a4-24992e37be05"
-version = "0.6.3"
+version = "0.6.4"
 
 [deps]
 AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"

diff --git a/src/Space.jl b/src/Space.jl
@@ -304,6 +304,8 @@ coefficients(f::AbstractVector,sp1::Space,::Type{T2}) where {T2<:Space} = coeffi
 ## coefficients defaults to calling Conversion, otherwise it tries to pipe through Chebyshev
 
 
+_Fun(v::AbstractVector, sp) = Fun(sp, v)
+_Fun(v, sp) = Fun(v, sp)
 function defaultcoefficients(f,a,b)
     ct=conversion_type(a,b) # gives a space that has a banded conversion to both a and b
 
@@ -321,7 +323,7 @@ function defaultcoefficients(f,a,b)
         end
         if spacescompatible(a,csp) || spacescompatible(b,csp)
             # b is csp too, so we are stuck, try Fun constructor
-            coefficients(default_Fun(Fun(a,f),b))
+            coefficients(default_Fun(_Fun(f,a),b))
         else
             coefficients(f,a,csp,b)
         end

diff --git a/test/SpacesTest.jl b/test/SpacesTest.jl
@@ -173,5 +173,9 @@ using ApproxFunOrthogonalPolynomials
         v = rand(4)
         v2 = transform(NormalizedChebyshev(), v)
         @test itransform(NormalizedChebyshev(), v2) ≈ v
+
+        f = Fun(x->x^2, Chebyshev())
+        v = coefficients(f, Chebyshev(), Legendre())
+        @test v ≈ coefficients(Fun(x->x^2, Legendre()))
     end
 end