Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prediction type check for Explicit strategy #201

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Jan 16, 2024

Closes #200

@ablaom ablaom requested a review from OkonSamuel January 16, 2024 06:14
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3293dc) 86.44% compared to head (961faee) 87.17%.
Report is 3 commits behind head on dev.

❗ Current head 961faee differs from pull request most recent head 53700b3. Consider uploading reports for the commit 53700b3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #201      +/-   ##
==========================================
+ Coverage   86.44%   87.17%   +0.73%     
==========================================
  Files          13       13              
  Lines         649      655       +6     
==========================================
+ Hits          561      571      +10     
+ Misses         88       84       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@OkonSamuel OkonSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Just a small note, this actually depends on the measure used. What if the user defined a measure that supports both probabilistic and deterministic predictions (That's possible). So it would be possible to use models with different prediction types.
Personally, I would have gone for a forced warning, that tells the user to make that the measure they are using could support that. But maybe that may also have it downsides.

@ablaom
Copy link
Member Author

ablaom commented Jan 23, 2024

(That's possible)

Good point, I hadn't thought of that. As it turns out it's not possible, but only because of bug. So I'm waiting on:

and then I'll update this PR.

@ablaom ablaom merged commit da15fb3 into dev Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add checks in the case of the Explicit strategy that all models have the same type of prediction
2 participants