Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now redundant sckitlearn hack #529

Closed
wants to merge 1 commit into from
Closed

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Sep 22, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a678c4) 76.76% compared to head (4681818) 76.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #529   +/-   ##
=======================================
  Coverage   76.76%   76.76%           
=======================================
  Files          16       16           
  Lines        1162     1162           
=======================================
  Hits          892      892           
  Misses        270      270           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom ablaom changed the base branch from dev to master September 22, 2023 01:55
@ablaom ablaom marked this pull request as draft September 22, 2023 01:55
@ablaom ablaom closed this Sep 22, 2023
@ablaom ablaom reopened this Sep 22, 2023
@ablaom ablaom changed the base branch from master to dev September 22, 2023 02:47
@ablaom ablaom marked this pull request as ready for review September 22, 2023 02:47
@ablaom
Copy link
Member Author

ablaom commented Sep 22, 2023

Checked check_registry works by first inspecting draft PR directly onto master.

@ablaom ablaom closed this Sep 22, 2023
@ablaom ablaom reopened this Sep 22, 2023
@ablaom ablaom requested a review from OkonSamuel September 22, 2023 02:48
@ablaom
Copy link
Member Author

ablaom commented Oct 6, 2023

@OkonSamuel Friendly reminder that a review would be nice.

@OkonSamuel
Copy link
Member

OkonSamuel commented Jan 9, 2024

I'm happy to drop it. But I'm trying to remember why we had it in the first place.
EDIT:
I remember now, For the linux builds we had an issue because the shared library used by Julia is different from that used by Conda. But since this PR runs it means that Julia dev team has updated the shared library used.
Rather than deleting it out totally, I recommend just comment the lines of code that aren't needed. Should in case we face a similar issue in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants