Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow InSample() resampling in IteratedModel #61

Merged
merged 8 commits into from
Jun 3, 2024
Merged

Allow InSample() resampling in IteratedModel #61

merged 8 commits into from
Jun 3, 2024

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented May 27, 2024

This PR also rewrites the docstring for TunedModel to improve it's clarity.

@ablaom ablaom requested a review from OkonSamuel May 27, 2024 02:07
@ablaom ablaom changed the title Allow InSample() resampling in TunedModel Allow InSample() resampling in IteratedModel May 28, 2024
src/constructors.jl Outdated Show resolved Hide resolved
src/constructors.jl Outdated Show resolved Hide resolved
src/constructors.jl Outdated Show resolved Hide resolved
Copy link
Member

@OkonSamuel OkonSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But I just had a few comments.

src/constructors.jl Outdated Show resolved Hide resolved
@ablaom ablaom merged commit 03cd01b into dev Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants