Support dark mode #199
Merged
Support dark mode #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If on iOS 13 or higher, returns a UIColor using the `init(dynamicProvider:)` initializer so it automatically adjusts to dark mode. Also switches out the `clouds` default color with the dynamic `skeletonDefault` color.
Make skeleton views respond to changes in system appearance by updating the skeleton view whenever the trait collection changes, so the colors change automatically with dark mode.
Juanpe
approved these changes
Oct 17, 2019
|
Hi @Wilsonator5000, thanks for contributing! Please, could you update the CHANGELOG file too? Thanks! |
leomodro
approved these changes
Oct 18, 2019
|
@Juanpe OK, I updated the CHANGELOG! |
|
Hey @Juanpe, what's the status on this PR? Thanks 😄 |
|
Thanks for contributing @Wilsonator5000 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for iOS 13 dark mode by using adaptive UIColors and swizzling
traitCollectionDidChange(_:), and changes the default color from.cloudsto the new.skeletonDefault(which is the same as.cloudsbut with a dark variant). It should resolve both #192 and #197.I also updated the example app to support dark mode, and added my changes to the English README — I'll need some help translating my changes to the other languages, though. Let me know what you think!