-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bounty module CLI commands #3102
Open
zeeshanakram3
wants to merge
16
commits into
Joystream:rhodes
Choose a base branch
from
zeeshanakram3:bounty_cli
base: rhodes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/joystream/pioneer-testnet/63VKGSBizLCT4N3K6x59HFyjM4jZ [Deployment for 0a0fd8c canceled] |
zeeshanakram3
added
CLI
Command Line Interface Tool
bounty-pallet
and removed
bounty-pallet
labels
Jan 25, 2022
…as for JSON input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR contains my initial work related to Bounty module CLI commands.
Related issue:
The purpose of this PR is to add the following Bounty management commands and describe their usage in cli package README.md;
bounty:bounty
bounty:bounties
bounty:createBounty
bounty:cancelBounty
bounty:vetoBounty
bounty:fundBounty
bounty:withdrawFunding
bounty:withdrawWorkEntrantFunds
bounty:announceWorkEntry
bounty:withdrawWorkEntry
bounty:entry
bounty:entries
bounty:submitWork
bounty:submitOracleJudgment
The code that needs double-check/review or has not been implemented is marked with
TODO
comments.The implementation details of the initial work are as follows:
JSBounty
&BountyMilestone
types in thetypes/src/bounty.ts
, these two types were missing in olympia base branch. I named bounty asJSBonuty
becauseaugment/augment-api-query.ts
already hadBounty
imported from Polkadot js treasury.BountyCommandBase
extendsRolesCommandBase
, defines the helpers function used in the bounties related commandsbounty:createBounty
command ensures that all bounty creation parameters are valid.bounty:cancelBounty
&bounty:vetoBounty
command ensures that bounty can only be canceled/vetoed if it's in theCreated
Stage and has zero contributions. Also, bounty can only be canceled by member who created it.announceWorkEntry
,withdrawWorkEntry
,submitWork
,submitOracleJudgment
etcsubmitOracleJudgment
extrinsic, previously on TS sideoracleJudgment
was defined asHowever the correct type that runtime extrinsic accepts is
where
OracleWorkEntryJudgment
corresponds to