linux-jovian: Revert breaking change from Quectel #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
added
1. type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #441
Testing implied checking how long steam dwelled on the logo between updater and startup, in addition to looking at
bluezunderhtop, and looking atsudo btmgmt.Oh, and also checking that e.g. my K480 Logitech Keyboard now works again.
This may require having had devices paired already, and maybe specific types of devices.
What was done
I'll add a side-note. I do not know how to test the original breakage this was intended to fix... But I also don't think it's necessary, since the changes show relatively trivially that yes, the change is wrong according to bluez, and that bluez itself now handles that.
Special thanks to @devusb who helped a lot by bisecting bluez before I got around to it.