Make module a no-op by default, and add check for no-op #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script can be used to check that the current repository state is a no-op.
This is the best semantics we have around wanting to use the steamos config... and conversely, not using steam and using the steamos semantics would be *weird* and I think it's fair for it to be opt-in.
samueldr
force-pushed
the
fix/no-op-oversight
branch
from
bbc4688 to
0c09446
Compare
K900
approved these changes
Oct 21, 2024
|
I had the same sentiment, but again... importing this repo and having to enable an option when not using Steam, and yet wanting the SteamOS semantics seems to me like it's a fair trade-off. The other situation around the SteamOS semantics (not wanting the SteamOS semantics while wanting the Steam experience) is already requiring an option to be set. So nothing changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling the steamos config with enabling steam is the best semantics we have around wanting to use the steamos config... and conversely, not using steam and using the steamos semantics would be weird and I think it's fair for it to be opt-in.
The
./support/nix-tests/check-no-ops.nixscript can be used to check that eval of the module is a no-op.A check has been added for that purpose.
Example check failing:
(Against this PR, with the modules/steamos no-op commit reverted)
Same check now working: