Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove jovian-steam-protocol-handler, just call normal Steam #423

Closed
wants to merge 1 commit into from

Conversation

K900
Copy link
Contributor

@K900 K900 commented Oct 16, 2024

Our bootstrap script can handle this now.

@K900 K900 requested a review from samueldr October 16, 2024 08:33
@K900 K900 closed this Oct 16, 2024
@K900
Copy link
Contributor Author

K900 commented Oct 16, 2024

So this fails because every one of our attempts of calling Steam calls it with -steamdeck, which breaks the rest of the argument passing, because idk. Presumably this is also why this was done this way upstream. I guess we keep the hack for now.

@samueldr
Copy link
Member

samueldr commented Oct 16, 2024

(from a discussion in the matrix room)

TLDR: argument parsing / "steam protocol handling" is uh... not uniified in the codebase, and some parts are handled with idiosyncrasies.

For example, the power button press handling:

~ $ echo 'steamed-hams -ifrunning -steamdeck steam://longpowerpress' > .steam/steam.pipe 
# fails

~ $ echo 'steamed-hams -ifrunning steam://longpowerpress -steamdeck' > .steam/steam.pipe                                             
#fails

~ $ echo 'steamed-hams -ifrunning steam://longpowerpress' > .steam/steam.pipe 
#works
  • argv[0] can be anything (no need for the string steam to exist)
  • argv[1] must be -ifrunning
  • argv[2] the power button press

This is not limited to the pipe, see:

~ $ steam-run .local/share/Steam/ubuntu12_32/steam-runtime/amd64/usr/bin/steam-runtime-steam-remote -ifrunning steam://longpowerpress -steamdeck
# fails

~ $ steam-run .local/share/Steam/ubuntu12_32/steam-runtime/amd64/usr/bin/steam-runtime-steam-remote -ifrunning steam://longpowerpress
# works

So the argv0 semantics follow a "command line call" semantic too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants