modules/overlay: add assertion to make sure we're building on 23.11 or higher #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
reviewed
Nov 18, 2023
modules/overlay.nix
Outdated
| assertions = [ | ||
| { | ||
| assertion = lib.versionAtLeast lib.version "23.11"; | ||
| message = "Jovian NixOS currently requires Nixpkgs 23.11 or newer to build."; |
There was a problem hiding this comment.
The actual suggestion should be to track nixos-unstable, rather than a specific version number, I think.
Suggested change
| message = "Jovian NixOS currently requires Nixpkgs 23.11 or newer to build."; | |
| message = "Jovian NixOS currently requires tracking nixos-unstable, (from 23.11 or newer) to build."; |
We will invariably soon be tracking 24.whatever whenever nixos-unstable and our usage of it breaks on 23.11. Feel free to reword like you see fit.
(otherwise I agree with the principle behind)
There was a problem hiding this comment.
We can always just increase the number if we start requiring a newer version. Though given we mostly all test against unstable...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids things like #217.