-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: resholve everything, big refactor gamescope-session #167
Conversation
Fixes #158 on my end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes and changes, not "done" yet, need to test and looks at some bits more carefully.
if [[ -n "$positional" ]]; then | ||
final+=("$value") | ||
elif [[ "$value" == "-n" ]]; then | ||
: | ||
else | ||
positional="y" | ||
final+=("$value") | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose I'm missing something from the initial WIP, but did this end-up needlessly doing the same thing in the first and last branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't change this bit at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But yes.
This comment was marked as outdated.
This comment was marked as outdated.
This will become important later
This will become important later (tm)
b19e95c
to
011a3f5
Compare
Doesn't build for me (NixOS/nixpkgs@e35dcc0, 011a3f5)
|
Resholve is currently busted on unstable, try latest unstable-small |
Hi there! In the next few minutes a fresh preview of the docs for f7efa70 will be available at https://www-jovian.github.io/Jovian-NixOS-PR167/. See also the generated diff at: https://github.com/www-jovian/Jovian-NixOS-PR167 Cheers! Beep-boop, this comment was auto-generated for www-jovian. |
afc6187
to
dfbc357
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Tested the OOBE last night, works fine. |
Also tested Vampire Survivors, the game that the comment in the upstream unit file says made them log to a file instead of the journal, and that also runs fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "verifying installation" thing is gone for me
Looks like everything works as expected. |
This basically gives us a working vendor flavored gamescope-session with no (as far as I've found) functional regressions, and also some improvements (powerbuttond, Steam as default URL handler, non-broken portals pending 1.18 in nixpkgs). Probably best viewed commit by commit, though the last one is big.
TODO