Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libffi from 3.2.1 to latest 3.4.6 #1755

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

kristapsk
Copy link
Member

@kristapsk kristapsk commented Jan 8, 2025

There are bunch of various bugfixes between 3.2.1 and 3.4.6.

Fixes #1752.

@kristapsk kristapsk added dependencies Pull requests that update a dependency file Installation labels Jan 8, 2025
@PulpCattel
Copy link
Member

I haven't tested it, but it makes sense to update.

I've verified the file at https://github.com/libffi/libffi/archive/v3.4.6.tar.gz matches the SHA256 9ac790464c1eb2f5ab5809e978a1683e9393131aede72d1b0a0703771d3c6cda

Is that 'doc patch' thing no longer needed because of the new version?

@kristapsk
Copy link
Member Author

Is that 'doc patch' thing no longer needed because of the new version?

Yes, that patch is included since v3.3. libffi/libffi@fa7a257

@kristapsk kristapsk marked this pull request as draft January 8, 2025 19:28
@kristapsk kristapsk marked this pull request as ready for review January 9, 2025 01:00
@kristapsk kristapsk merged commit 746e832 into JoinMarket-Org:master Jan 9, 2025
11 checks passed
@kristapsk kristapsk deleted the libffi-3.4.6 branch January 9, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Installation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install.sh is failing to build libffi on gentoo
2 participants