Add type hints to secp256k1_main.py and secp256k1_transaction.py
#1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristapsk
force-pushed
the
secp256k1-type-hints
branch
4 times, most recently
from
9e340d9 to
20d7860
Compare
|
Rebased |
roshii
suggested changes
Dec 5, 2023
Co-authored-by: roshii <[email protected]>
kristapsk
force-pushed
the
secp256k1-type-hints
branch
from
20d7860 to
7ebbacf
Compare
|
Addressed review comments. |
roshii
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's sometimes especially time consuming with this part of JM codebase for me to figure out types for function arguments and return values, usually I end up looking at
python-bitcointxcode.Changed return type of
get_equal_outs()fromUnion[bool, List[CTxOut]]toOptional[List[CTxOut]], only caller (scripts/snicker/snicker-recovery.py) already handled this.