General Refactor #39
Merged
General Refactor #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the route creation is centralised in Tab, and just inheritted by all subtabs, so all subtabs just need to focus on creating their JSON responses, and not the intricacies of Flask route creation. Less copied code.
Remove some duplication by providing an easy way to get a flattened version of the gui_tree
Max page height is now 100% and not 100% + 1/3*100% margin.
Big refactor move the logic around 'what should we do for each tab re- processing, and viewing. Now instead of an expanding list of if/else statements in the task queue, there is one if/else in each tab! Yay!
This allows us to check that plot, table, and image data is serialised correctly allowing it to be placed into S3.
I generalised cumulative plots. So instead of having two plot files for cumulative time and cumulative distance, now I have 1 file for cumulative time, distance, elevation, and kudos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a great PR name, but I did some of the following things:
backend_hookandfrontend_hooktab logic.