Handle missing cookies issue #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue somewhere that results in users requesting data from this website without session cookies. I could reproduce on my phone by logging in, hard-closing the browser, and then re-opening it. On re-open the browser attempts to load the 'logged in' screen with no cookies. This PR does the following: 1: Delete a whole lot of random stuff from the backend. We don't need any of the html, css, and javascript any more since next.js handles everything now. 2: Wraps all fetch requests so that if a 401 Unauthorized is received, then the user gets re-routed to home. 3: The backend routes now have a decorator to check for the session cookie instead of doing it in each route individually, and instead of manually rerouting to 'index' which doesn't exist, they just return 401 status codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue somewhere that results in users requesting data from this website without session cookies. I could reproduce on my phone by logging in, hard-closing the browser, and then re-opening it. On re-open the browser attempts to load the 'logged in' screen with no cookies.
This PR does the following:
1: Delete a whole lot of random stuff from the backend. We don't need any of the html, css, and javascript any more since next.js handles everything now.
2: Wraps all fetch requests so that if a 401 Unauthorized is received, then the user gets re-routed to home.
3: The backend routes now have a decorator to check for the session cookie instead of doing it in each route individually, and instead of manually rerouting to 'index' which doesn't exist, they just return 401 status codes.