Skip to content

Commit

Permalink
Merge pull request #33 from Jittojoyes98/develop
Browse files Browse the repository at this point in the history
fix: changes to image url.
  • Loading branch information
Jittojoyes98 authored Jun 25, 2024
2 parents 7cca9cc + 27c05a1 commit 834ebdc
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 4 deletions.
Binary file added assets/hero-poster.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed public/hero-poster.webp
Binary file not shown.
Binary file removed src/HomePage/hero-poster.webp
Binary file not shown.
3 changes: 2 additions & 1 deletion src/HomePage/index.jsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import React from "react";
import { ImageAssets } from "../_helpers/images";

const HomePage = () => {
return (
<div className="home-wrapper">
<div className="home-main">
<section data-testid="homepage-hero" className="home-hero-section">
<img src={`./hero-poster.webp`} alt="hero image" />
<img src={ImageAssets.droformImage} alt="hero image" />
<div className="centre-div-vertical">
<div>
<h1 className="big-header">Welcome to dropform</h1>
Expand Down
5 changes: 5 additions & 0 deletions src/_helpers/images.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import LogoSvg from "../../assets/logo.svg";
import HeroImage from "../../assets/hero-poster.png";

export const SvgAssets = {
dropformLogo: LogoSvg,
};

export const ImageAssets = {
droformImage: HeroImage,
};
7 changes: 5 additions & 2 deletions src/_layout/Header.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,12 @@ const Header = ({ layout }) => {
className="dropform-svg"
style={{ width: "30px", height: "30px" }}
/>
<p className="logo-text-light margin-rl-fix full-height centre-div">
<a
href="/"
className="logo-text-light margin-rl-fix full-height centre-div"
>
Dropform
</p>
</a>
</>
);
} else {
Expand Down
1 change: 1 addition & 0 deletions src/_styles/theme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ ul {

a {
text-decoration: none;
color: $body-text-color;
}

button {
Expand Down
4 changes: 3 additions & 1 deletion webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ module.exports = (env) => {
{
test: /\.(png|woff|woff2|eot|ttf|svg)$/, // to import images and fonts
loader: "url-loader",
options: { limit: false },
options: {
limit: false,
},
},
],
},
Expand Down

0 comments on commit 834ebdc

Please sign in to comment.