Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Strip logs in the release version #20

Merged
merged 1 commit into from
Sep 13, 2024
Merged

[WIP] Strip logs in the release version #20

merged 1 commit into from
Sep 13, 2024

Conversation

JingMatrix
Copy link
Owner

@JingMatrix JingMatrix commented Sep 1, 2024

For people who are interested in stripping logs, you may continue to work on this pull-request.
Based on LSPosed#2822, credited to @msvamp.

@JingMatrix JingMatrix linked an issue Sep 1, 2024 that may be closed by this pull request
@BM570
Copy link

BM570 commented Sep 6, 2024

I know for sure that when you run getprop in a terminal on an unmodified Android device without touching its bootloader, without rooting, and without enabling developer options - then there are no properties starting with persist.log or persist.logd on the device. LSPosed creates them in the first place and then the app in question, stops working.
I made this PR only to make a provision to prevent LSPosed from touching these properties.

Originally posted by @msvamp in LSPosed#2822 (comment)

That makes the logging a detection vector, for apps to detect active LSPosed (an indicator of root). Needs to be bypassed this way, if user has apps that use this hideous thing to detect you.

What else needs to be done, or does it basically work?

@JingMatrix
Copy link
Owner Author

According to this comment, #14 (comment), it basically works.

@BM570
Copy link

BM570 commented Sep 8, 2024

Yes. Please merge :)

@BlueCat300
Copy link

No need to delete logs! They are needed for developing modules AND informing developers about errors in modules.

@JingMatrix JingMatrix force-pushed the master branch 5 times, most recently from 99a538e to 4c4df22 Compare September 12, 2024 17:09
JingMatrix pushed a commit that referenced this pull request Sep 12, 2024
build(deps): upgrade 4 submodules to their latest commits
Requested by #14, a switch is added to the release version.
Patch of msvamp rejected in original repository
mywalk added ui interface

Co-authored-by: mywalk <[email protected]>
@JingMatrix
Copy link
Owner Author

@BlueCat300 It is only for release version. And if users want to report bugs, you may require them to use a debug version.

@JingMatrix JingMatrix marked this pull request as ready for review September 13, 2024 15:29
@JingMatrix JingMatrix merged commit 076acab into master Sep 13, 2024
JingMatrix added a commit that referenced this pull request Sep 17, 2024
Requested by #14, a switch is added to the release version.
Patch of msvamp rejected in original repository
mywalk added ui interface

Co-authored-by: mywalk <[email protected]>
@JingMatrix JingMatrix deleted the strip_log branch September 17, 2024 10:39
JingMatrix added a commit that referenced this pull request Sep 18, 2024
Requested by #14, a switch is added to the release version.
Patch of msvamp rejected in original repository
mywalk added ui interface

Co-authored-by: mywalk <[email protected]>
JingMatrix added a commit that referenced this pull request Sep 22, 2024
Requested by #14, a switch is added to the release version.
Patch of msvamp rejected in original repository
mywalk added ui interface

Co-authored-by: mywalk <[email protected]>
JingMatrix added a commit that referenced this pull request Oct 17, 2024
Requested by #14, a switch is added to the release version.
Patch of msvamp rejected in original repository
mywalk added ui interface

Co-authored-by: mywalk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass NativeTest 27 check!
4 participants