Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve equal access #269

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Improve equal access #269

merged 2 commits into from
Dec 29, 2024

Conversation

Jikoo
Copy link
Owner

@Jikoo Jikoo commented Dec 29, 2024

  • Respect deny mode for equals if viewer cannot edit
  • Revert default mode to allow equal access
    • Several people have gotten confused by the view-only default for equals - it is not intuitive, and OI generally Just Works(TM) with no config. This will make OI more functional out of the box on basic servers with no permissions.

I have verified that access levels work correctly (assuming target is online; still no offline perms support).
Closes #268

@Jikoo Jikoo enabled auto-merge (squash) December 29, 2024 13:41
@Jikoo Jikoo merged commit 9196ab3 into master Dec 29, 2024
2 checks passed
@Jikoo Jikoo deleted the dev/improve-equal-access branch December 29, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate equal access view-only
1 participant