Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix Chromium sandbox issue of manager web test #2317

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

jyyi1
Copy link
Contributor

@jyyi1 jyyi1 commented Jan 2, 2025

This PR resolves the sandbox error encountered during server manager web tests:

Cannot start ChromiumHeadless: No usable sandbox!

This error is caused by the more restricted unprivileged user namespaces feature introduced in Ubuntu 23. It's a known limitation and many chromium based products (including electron) are affected by this change.

This PR switches the runner image from ubuntu:latest (which is Ubuntu 24) to ubuntu:22.04.

@jyyi1 jyyi1 changed the title ci: fix sandbox issue of chromium ci: fix Chromium sandbox issue of Karma test Jan 2, 2025
@jyyi1 jyyi1 changed the title ci: fix Chromium sandbox issue of Karma test ci: fix Chromium sandbox issue of manager unit test Jan 2, 2025
@jyyi1 jyyi1 changed the title ci: fix Chromium sandbox issue of manager unit test ci: fix Chromium sandbox issue of manager web test Jan 2, 2025
@jyyi1 jyyi1 marked this pull request as ready for review January 2, 2025 22:21
@jyyi1 jyyi1 requested a review from a team as a code owner January 2, 2025 22:21
@jyyi1 jyyi1 requested review from fortuna and sbruens January 2, 2025 22:21
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this fixes the CI, it seems we still need to actually fix the underlying issue.
Is this the reason why the Electron Client is having issues?

@jyyi1
Copy link
Contributor Author

jyyi1 commented Jan 3, 2025

While this fixes the CI, it seems we still need to actually fix the underlying issue. Is this the reason why the Electron Client is having issues?

Yes, one of the major issues.

@jyyi1 jyyi1 merged commit 5749a1f into master Jan 3, 2025
31 checks passed
@jyyi1 jyyi1 deleted the junyi/fix-ci-manager-test branch January 3, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants