Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager): server allowance usage component #2311
base: master
Are you sure you want to change the base?
feat(manager): server allowance usage component #2311
Changes from 1 commit
0e8c2fa
39ef884
3744921
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some unit tests to validate the formatted values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we don't really have UI unit tests set up yet - well, we have this approach, but yikes
Some options here -
querySelector
andshadowRoot
- not ideal imo. Klugy, cumbersome, fragile.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with something like
querySelector
for now. That's how I tested the contact form logic in the absence of a better testing framework. I really just want something here to prevent regression of this formatting.Check failure on line 112 in server_manager/www/views/server_view/server_allowance_usage/index.ts
GitHub Actions / Lint
Check failure on line 112 in server_manager/www/views/server_view/server_allowance_usage/index.ts
GitHub Actions / Lint