feat(www): add a form field to distinguish new style form submissions…

… in salesforce (#1748)

* feat(www): add a form field to distinguish legacy from new submitted forms in sentry and salesforce

* Add test for sending the values to error reporter.

* Use a version instead of a boolean on the app side.

src/www/shared/error_reporter.ts

@@ -15,7 +15,7 @@
 import * as Sentry from '@sentry/browser';
 import {Integration as SentryIntegration} from '@sentry/types';
 
-export type Tags = {[id: string]: string};
+export type Tags = {[id: string]: string | boolean | number};
 
 export interface OutlineErrorReporter {
   report(userFeedback: string, feedbackCategory: string, userEmail?: string, tags?: Tags): Promise<void>;

src/www/views/contact_view/index.spec.ts

@@ -145,6 +145,23 @@ describe('ContactView client variant', () => {
         expect(supportForm).not.toBeNull();
       });
 
+      it('reports correct values to error reporter on completion of support form', async () => {
+        const supportForm: SupportForm = el.shadowRoot!.querySelector('support-form')!;
+        supportForm.values.email = '[email protected]';
+        supportForm.values.subject = 'Test Subject';
+        supportForm.values.accessKeySource = 'a friend';
+        supportForm.values.description = 'Test Description';
+        supportForm.valid = true;
+        supportForm.dispatchEvent(new CustomEvent('submit'));
+        await nextFrame();
+
+        expect(mockErrorReporter.report).toHaveBeenCalledWith('Test Description', 'general', '[email protected]', {
+          subject: 'Test Subject',
+          accessKeySource: 'a friend',
+          formVersion: 2,
+        });
+      });
+
       it('emits success event on completion of support form', async () => {
         const listener = oneEvent(el, 'success');
 

src/www/views/contact_view/index.ts

@@ -177,7 +177,10 @@ export class ContactView extends LitElement {
 
     const {description, email, ...tags} = this.formValues as ValidFormValues;
     try {
-      await this.errorReporter.report(description, this.selectedIssueType?.toString() ?? 'unknown', email, {...tags});
+      await this.errorReporter.report(description, this.selectedIssueType?.toString() ?? 'unknown', email, {
+        ...tags,
+        formVersion: 2,
+      });
     } catch (e) {
       console.error(`Failed to send feedback report: ${e.message}`);
       this.isFormSubmitting = false;