[ISSUE apache#7979] Fix timerWheel message metric (apache#7980)

* fix metric in TimerWheel * fix metric in TimerWheel * fix message metric in TimerWheel * fix message metric in TimerWheel
Jianing-Xu · Apr 1, 2024 · bf24ffd · bf24ffd
1 parent 28565a3
commit bf24ffd
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java b/store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java
@@ -1556,6 +1556,8 @@ public void run() {
                             if (null != msgExt) {
                                 if (needDelete(tr.getMagic()) && !needRoll(tr.getMagic())) {
                                     if (msgExt.getProperty(MessageConst.PROPERTY_TIMER_DEL_UNIQKEY) != null && tr.getDeleteList() != null) {
+                                        //Execute metric plus one for messages that fail to be deleted
+                                        addMetric(msgExt, 1);
                                         tr.getDeleteList().add(msgExt.getProperty(MessageConst.PROPERTY_TIMER_DEL_UNIQKEY));
                                     }
                                     tr.idempotentRelease();
@@ -1566,6 +1568,8 @@ public void run() {
                                         LOGGER.warn("No uniqueKey for msg:{}", msgExt);
                                     }
                                     if (null != uniqueKey && tr.getDeleteList() != null && tr.getDeleteList().size() > 0 && tr.getDeleteList().contains(uniqueKey)) {
+                                        //Normally, it cancels out with the +1 above
+                                        addMetric(msgExt, -1);
                                         doRes = true;
                                         tr.idempotentRelease();
                                         perfCounterTicks.getCounter("dequeue_delete").flow(1);