[ISSUE apache#7868] Use entrySet to close channel

Jianing-Xu · Feb 29, 2024 · af900e9 · af900e9
1 parent 01761bd
commit af900e9
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
@@ -362,8 +362,8 @@ public void shutdown() {
         try {
             this.timer.stop();
 
-            for (String addr : this.channelTables.keySet()) {
-                this.channelTables.get(addr).close();
+            for (Map.Entry<String, ChannelWrapper> channel : this.channelTables.entrySet()) {
+                channel.getValue().close();
             }
 
             this.channelWrapperTables.clear();
@@ -943,8 +943,9 @@ protected void scanChannelTablesOfNameServer() {
             return;
         }
 
-        for (String addr : this.channelTables.keySet()) {
-            ChannelWrapper channelWrapper = this.channelTables.get(addr);
+        for (Map.Entry<String, ChannelWrapper> entry : this.channelTables.entrySet()) {
+            String addr = entry.getKey();
+            ChannelWrapper channelWrapper = entry.getValue();
             if (channelWrapper == null) {
                 continue;
             }