[ISSUE apache#7904] use string builder to concat string

Jianing-Xu · Mar 14, 2024 · ab9a401 · ab9a401
1 parent 6d47404
commit ab9a401
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/common/src/main/java/org/apache/rocketmq/common/namesrv/DefaultTopAddressing.java b/common/src/main/java/org/apache/rocketmq/common/namesrv/DefaultTopAddressing.java
@@ -107,27 +107,27 @@ public void registerChangeCallBack(NameServerUpdateCallback changeCallBack) {
     }
 
     public final String fetchNSAddr(boolean verbose, long timeoutMills) {
-        String url = this.wsAddr;
+        StringBuilder url = new StringBuilder(this.wsAddr);
         try {
             if (null != para && para.size() > 0) {
                 if (!UtilAll.isBlank(this.unitName)) {
-                    url = url + "-" + this.unitName + "?nofix=1&";
+                    url.append("-").append(this.unitName).append("?nofix=1&");
                 }
                 else {
-                    url = url + "?";
+                    url.append("?");
                 }
                 for (Map.Entry<String, String> entry : this.para.entrySet()) {
-                    url += entry.getKey() + "=" + entry.getValue() + "&";
+                    url.append(entry.getKey()).append("=").append(entry.getValue()).append("&");
                 }
-                url = url.substring(0, url.length() - 1);
+                url = new StringBuilder(url.substring(0, url.length() - 1));
             }
             else {
                 if (!UtilAll.isBlank(this.unitName)) {
-                    url = url + "-" + this.unitName + "?nofix=1";
+                    url.append("-").append(this.unitName).append("?nofix=1");
                 }
             }
 
-            HttpTinyClient.HttpResult result = HttpTinyClient.httpGet(url, null, null, "UTF-8", timeoutMills);
+            HttpTinyClient.HttpResult result = HttpTinyClient.httpGet(url.toString(), null, null, "UTF-8", timeoutMills);
             if (200 == result.code) {
                 String responseStr = result.content;
                 if (responseStr != null) {