-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isMaximized and setMaximized methods to PlatformOperations #916
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR! Sorry for the delay, I plan to look at it more closely later. There are potential race conditions with the current code, I am still not sure if they are relevant or not, I need to look at it more carefully. |
Any updates on this? |
Sorry, no update |
A preliminary review:
But the current logic may not guarantee that. Also I am not sure if the native functions also can guarantee it. If not, we should write workarounds. |
Related to: JetBrains/compose-multiplatform-core#1148
Hi,
I added
setMaximized
methods toPlatformOperations
which is using a native implementation for macos.I added
maximized
property in HardwareLayer and SkiaLayer.awt.This will fix a problem that we have on Compose Desktop when we try to do something like this: floating -> fullscreen -> maximized, the window will stay fullscreen, more details in the PR above.
The swing implementation on Windows and Linux is not tested yet.
The current implementation is not final, but it's working, so let me know what you think.