fix: compileWasm on Windows #742
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So I've tried to build skiko by myself and encountered few issues: 1. [emscripten](https://github.com/emscripten-core/emscripten) contains both `emcc` (shell script) and `emcc.bat` files but [OS.compilerForTarget](https://github.com/nev3rfail/skiko/blob/52c586f9b509715e7466f0355e440a39f12f187a/skiko/buildSrc/src/main/kotlin/properties.kt#L43) returns "emcc" which causes Gradle to create tasks that attempt to execute a non-executable and the fix is to add ".bat" to `emcc` executable. 2. Paths to includes are broken with a combination of Windows host and WASM because someone in "emcc.bat -> emcc.py -> clang.exe" chain eats Windows' directory separators. Solution is to create one more arg builder that would convert `\` to `\\` but also wouldn't convert arguments themselves like BaseVisualStudioBuildToolsArgBuilder does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I've tried to build skiko by myself and encountered few issues:
emscripten contains both
emcc(shell script) andemcc.batfiles but OS.compilerForTarget returns "emcc" which causes Gradle to create tasks that attempt to execute a non-executable and the fix is to add ".bat" toemccexecutable.Paths to includes are broken with a combination of Windows host and WASM because someone in "emcc.bat -> emcc.py -> clang.exe" chain eats Windows' directory separators. Solution is to create one more arg builder that would convert
\to\\but also wouldn't convert arguments themselves like BaseVisualStudioBuildToolsArgBuilder does.