Native Notifications [WIP] #462
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olonho
reviewed
Jan 27, 2022
| import kotlin.native.concurrent.freeze | ||
|
|
||
| internal actual suspend fun sendNotification(notification: Notification) { | ||
| val nc = UNUserNotificationCenter.currentNotificationCenter().freeze() |
There was a problem hiding this comment.
No need to freeze here, this is Objective-C object.
olonho
reviewed
Jan 27, 2022
| @@ -11,7 +11,7 @@ import kotlin.math.sin | |||
| import kotlin.math.PI | |||
| import kotlin.math.pow | |||
|
|
|||
| class Clocks(private val layer: SkiaLayer): SkikoView { | |||
| open class Clocks(private val layer: SkiaLayer): SkikoView { | |||
There was a problem hiding this comment.
Temporarily opened to add custom key binding for macOS
olonho
reviewed
Jan 27, 2022
| super.onKeyboardEvent(event) | ||
| if (event.kind == SkikoKeyboardEventKind.DOWN) when (event.key) { | ||
| SkikoKey.KEY_N -> runBlocking { | ||
| Notification( |
There was a problem hiding this comment.
Hmm, why runBlocking? Cannot we just run it as suspend on SkikoDispatchers.Main dispatcher?
olonho
reviewed
Jan 27, 2022
| import platform.Foundation.NSMakeRect | ||
| import platform.Foundation.NSSelectorFromString | ||
| import platform.darwin.NSObject | ||
| import org.jetbrains.skiko.notifications.Notification |
There was a problem hiding this comment.
Not sure if notifications deserve their own package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.