Skip to content

Commit

Permalink
pythongh-117865: Defer import of re in ast
Browse files Browse the repository at this point in the history
This is used only by ast.get_source_segment(), so it seems sensible to avoid importing it.
  • Loading branch information
JelleZijlstra committed May 25, 2024
1 parent b48a3db commit 9cbb64c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 6 additions & 2 deletions Lib/ast.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
:license: Python License.
"""
import sys
import re
from _ast import *
from contextlib import contextmanager, nullcontext
from enum import IntEnum, auto, _simple_enum
Expand Down Expand Up @@ -325,12 +324,17 @@ def get_docstring(node, clean=True):
return text


_line_pattern = re.compile(r"(.*?(?:\r\n|\n|\r|$))")
_line_pattern = None
def _splitlines_no_ff(source, maxlines=None):
"""Split a string into lines ignoring form feed and other chars.
This mimics how the Python parser splits source code.
"""
global _line_pattern
if _line_pattern is None:
import re
_line_pattern = re.compile(r"(.*?(?:\r\n|\n|\r|$))")

lines = []
for lineno, match in enumerate(_line_pattern.finditer(source), 1):
if maxlines is not None and lineno > maxlines:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Improve the import time of the :mod:`ast` module by deferring the import of
:mod:`re`. Patch by Jelle Zijlstra.

0 comments on commit 9cbb64c

Please sign in to comment.