make an MC recon file for 2019, 2021 spaced readout #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgignac
requested changes
Dec 14, 2024
There was a problem hiding this comment.
Thanks @bloodyyugo ! Add a few comments, mostly just to confirm changes. I think the biggest comment is on the KFOutputDriver ... if we keep this in, you will need to merge that driver in too.
...g-files/src/main/resources/org/hps/steering/recon/PhysicsRun2019MCRecon_KF_WithSpacing.lcsim
Outdated
Show resolved
Hide resolved
...g-files/src/main/resources/org/hps/steering/recon/PhysicsRun2019MCRecon_KF_WithSpacing.lcsim
Show resolved
Hide resolved
...g-files/src/main/resources/org/hps/steering/recon/PhysicsRun2019MCRecon_KF_WithSpacing.lcsim
Show resolved
Hide resolved
...g-files/src/main/resources/org/hps/steering/recon/PhysicsRun2019MCRecon_KF_WithSpacing.lcsim
Show resolved
Hide resolved
I am adding the tracking changes to this MC steering file
|
I have added the optimized parameters into the KalmanPatRecDriver. Should be the same as used in data as it was validated in both. |
|
I believe now all the reco changes I have optimized for have been incorporated. |
mgignac
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a steering file for 2019/2021 MC readout. This has Rory's fitting/clustering fixes. The SVT hit time corrections should put the track time to around ~0 and the cluster-track time offset in the recon-particle driver should be correct.
I ran this on some MC I had and it runs and gives decent tracks/clusters.