add readout steering file for 2021 MC with single2&single3 triggers #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloodyyugo
approved these changes
Dec 13, 2024
mgignac
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Looks good to me -- only (picky) comment would be whether you want to be explicit and specify the triggerType in the SinglesTrigger3 instead of rely on the default in the source code, incase e.g. someone were to change the source code at another time. Anyways, approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new steering file for 2021 MC with single2&single3 triggers is a copy of the steering file for 2019 MC: PhysicsRun2019TrigSinglesWithPulserDataMerging.lcsim.
The only change is factorGainConversion from 0.000833333 for 4.55 GeV beam of 2019 to 0.0008125 for 3.74 GeV beam of 2021.
The factor is for hodoscope gain conversion from self-defined unit/ADC to MeV/ADC.
Parameter setup is determined by distribution of energy deposit for hodoscope hits from SLIC.
Effect of the change on hodoscope patterns in the readout system is almost negligible since the change is slight and threshold for hodoscope hits is quite low.