Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run tests on darwin #121

Merged
merged 2 commits into from
Oct 13, 2023
Merged

ci: run tests on darwin #121

merged 2 commits into from
Oct 13, 2023

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Sep 28, 2023 •
edited
Loading

close #119

@c-dilks
Copy link
Member Author

c-dilks commented Sep 28, 2023 •
edited
Loading

As expected, the macos-latest tests are failing because of #118.

EDIT: which is currently version 12, though runners with version 13 are also available.

@c-dilks c-dilks marked this pull request as ready for review September 29, 2023 19:56
@c-dilks c-dilks marked this pull request as draft October 13, 2023 17:27
@c-dilks
Copy link
Member Author

c-dilks commented Oct 13, 2023

Github limits the max number of concurrent MacOS runner jobs more than the Ubuntu runners, so let's limit the test matrix to one job for MacOS.

@c-dilks c-dilks marked this pull request as ready for review October 13, 2023 17:57
@c-dilks c-dilks marked this pull request as draft October 13, 2023 18:41
@c-dilks c-dilks marked this pull request as ready for review October 13, 2023 19:52
@c-dilks
Copy link
Member Author

c-dilks commented Oct 13, 2023

Ready!

@baltzell baltzell merged commit 96920e9 into JeffersonLab:development Oct 13, 2023
12 checks passed
@c-dilks c-dilks deleted the ci-darwin branch October 13, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baltzell baltzell baltzell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add darwin build testing to CI
2 participants
@c-dilks @baltzell